Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-24 [flex] script & model #141

Closed
wants to merge 5 commits into from
Closed

GH-24 [flex] script & model #141

wants to merge 5 commits into from

Conversation

npeltier
Copy link
Contributor

@npeltier npeltier commented Aug 28, 2020

this component will not be done in one PR commit :-) ( no dialog yet) on docs by:

  • making responsive configuration more complex (with an instanciation of it for docs in content,
  • added a FlexModel.getId, even if we might want to move this to some abstract model later,
  • fixed a few bad resource types here & there
  • got fore, back ground colors, gap container & minheight working,
  • introduced StyleService and added shadow & border that way

this component will not be done in one PR :-) got fore & back ground colors working ( no dialog yet) on docs by:
- making responsive configuration more complex (with an instanciation of it for docs in content,
- added a FlexModel.getId, even if we might want to move this to some abstract model later,
- fixed a few bad resource types here & there
@npeltier npeltier changed the title GH-24 [flex] get the colors working GH-24 [flex] script & model Aug 31, 2020
- StyleService checks for current component's type styleWorker property, and registered workers, and computes one style for all,
- Shadow worker + UT
- Border worker + UT
@npeltier
Copy link
Contributor Author

npeltier commented Sep 8, 2020

while this is growing, created adobe/htl-spec#89 as it would have been nice for that one :-D

@npeltier
Copy link
Contributor Author

npeltier commented Sep 9, 2020

closing that one to open one against dedicated branch

@npeltier npeltier closed this Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant