feat: add capability to patch block config at runtime #246
Conversation
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
|
|
|
@rofe Right, forgot I had the repo as private. I opened it up now. |
scripts/lib-franklin.js
Outdated
| const original = { blockName, cssPath, jsPath }; | ||
| return window.hlx.patchBlockConfig.reduce( | ||
| (config, fn) => (typeof fn === 'function' ? fn(config, original) : config) || config, | ||
| { blockName, cssPath, jsPath }, |
There was a problem hiding this comment.
Why not original to initialize the reduce?
There was a problem hiding this comment.
Was just to avoid someone modifying it inside the fn and potentially breaking the values.
Co-authored-by: Lars Trieloff <lars@trieloff.net>
|
|
Ideally yes. If there isn't already, there should probably be an experimentation page in the developer section of www.hlx.live. |
|
@rofe This doesn't add experimentation, just an extension point for changing how block-related files (JS, CSS) are loaded. I was wondering if extension points are documented somewhere and if I need to add this to it. |
|
# [1.3.0](v1.2.2...v1.3.0) (2023-11-30) ### Bug Fixes * attempt to fix release ([5bb8f73](5bb8f73)) * **build:** fix org in issues URL ([7226d84](7226d84)) * **build:** no double slashes in issues url ([1191064](1191064)) * **github:** increase default permissions for cleanup action ([f8ed051](f8ed051)) * **github:** restrict running of action to initial commit on main branch ([1a990c2](1a990c2)) * icons no more svgs ([#267](#267)) ([2d4cfa7](2d4cfa7)) * **lib:** update scripts/aem.js to aem.js@1.3.2 ([#266](#266)) ([2d61c6a](2d61c6a)) * rescope icon identifiers to avoid clashing references across icons ([#241](#241)) ([e8dc533](e8dc533)), closes [#235](#235) * sampleRUM always for checkpoint to be called even if RUM not selected ([fcca39d](fcca39d)) * trigger release ([afbd201](afbd201)) ### Features * add capability to patch block config at runtime ([#246](#246)) ([a774acc](a774acc)) * enable listeners to all RUM events, not just the sampled ones ([871ede4](871ede4)) * use aem.js ([#255](#255)) ([f5ab4df](f5ab4df))
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
We've had several cases in the past where we needed to override the default block config logic when loading blocks:
To make maintaining those downstream projects easier, I propose to directly add an extension mechanism so we have fewer modifications to the
lib-franklin.jsfile.Test URLs:
Sample usage: https://github.com/ramboz/franklin-experience-decisioning/blob/main/scripts/experience-decisioning/index.js#L359-L417