Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2913: remove category_uid from remove filter map #924

Merged
merged 6 commits into from
Jun 22, 2022

Conversation

buuhuu
Copy link
Contributor

@buuhuu buuhuu commented Jun 15, 2022

Description

With #643 we remove the category_uid filter request parameter when the value can be parsed from the url which is the case for PLPs. This worked well for adding facet filters, but we missed to handle removing the facets.

This change removes the category_uid also from a SearchAggregations remove filter map.

Related Issue

CIF-2913
#643

Motivation and Context

Usually requests that contain request parameters are not cached by the dispatcher. To increase the cache ratio we remove unnecessary request parameters for the product list component so that the dispatcher cached page can be served.

How Has This Been Tested?

Unit tests, locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@buuhuu buuhuu marked this pull request as ready for review June 16, 2022 13:40
@buuhuu buuhuu changed the title CIF-2913: remove category_uid from remove filter map as well CIF-2913: remove category_uid from remove filter map Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #924 (a386ab3) into master (1775a1e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #924      +/-   ##
============================================
+ Coverage     89.71%   89.73%   +0.01%     
- Complexity     2016     2018       +2     
============================================
  Files           338      338              
  Lines          9260     9261       +1     
  Branches       1316     1318       +2     
============================================
+ Hits           8308     8310       +2     
+ Misses          679      678       -1     
  Partials        273      273              
Flag Coverage Δ
integration 52.83% <100.00%> (+0.02%) ⬆️
jest 86.38% <ø> (ø)
karma 95.68% <ø> (ø)
unittests 88.83% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ch/internal/services/SearchResultsServiceImpl.java 95.68% <100.00%> (+0.01%) ⬆️
.../search/internal/models/SearchAggregationImpl.java 100.00% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1775a1e...a386ab3. Read the comment docs.

@laurentiumagureanu laurentiumagureanu merged commit e497022 into master Jun 22, 2022
@laurentiumagureanu laurentiumagureanu deleted the issue/CIF-2913 branch June 22, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants