CIF-2827: Placeholder XF in product list component #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #930 +/- ##
============================================
- Coverage 89.71% 89.57% -0.14%
- Complexity 2154 2172 +18
============================================
Files 347 352 +5
Lines 9673 9764 +91
Branches 1394 1405 +11
============================================
+ Hits 8678 8746 +68
- Misses 713 727 +14
- Partials 282 291 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
buuhuu
requested changes
Jun 24, 2022
...n/java/com/adobe/cq/commerce/core/components/models/productcollection/ProductCollection.java
Outdated
Show resolved
Hide resolved
...cr_root/apps/core/cif/components/commerce/productlist/v2/productlist/_cq_dialog/.content.xml
Outdated
Show resolved
Hide resolved
...n/java/com/adobe/cq/commerce/core/components/models/productcollection/ProductCollection.java
Outdated
Show resolved
Hide resolved
...va/com/adobe/cq/commerce/core/components/internal/models/v1/productlist/ProductListImpl.java
Outdated
Show resolved
Hide resolved
...va/com/adobe/cq/commerce/core/components/internal/models/v1/productlist/ProductListImpl.java
Outdated
Show resolved
Hide resolved
|
We may need an update for the readme and the examples project to show the cool new feature. |
herzog31
approved these changes
Jul 7, 2022
...merce/core/components/services/experiencefragments/CommerceExperienceFragmentsRetriever.java
Outdated
Show resolved
Hide resolved
...main/content/jcr_root/apps/core/cif/components/commerce/productlist/v2/productlist/README.md
Outdated
Show resolved
Hide resolved
LSantha
reviewed
Jul 7, 2022
...main/content/jcr_root/apps/core/cif/components/commerce/productlist/v2/productlist/README.md
Outdated
Show resolved
Hide resolved
buuhuu
requested changes
Jul 7, 2022
...cr_root/apps/core/cif/components/commerce/productlist/v2/productlist/_cq_dialog/.content.xml
Outdated
Show resolved
Hide resolved
LSantha
reviewed
Jul 7, 2022
| public class ProductListImpl extends ProductCollectionImpl implements ProductList { | ||
|
|
||
| public static final String RESOURCE_TYPE = "core/cif/components/commerce/productlist/v1/productlist"; | ||
| protected static final String PLACEHOLDER_DATA = "productlist-component-placeholder-data.json"; | ||
| protected static final String PN_FRAGMENT_LOCATION = "fragmentLocation"; | ||
| protected static final String PN_FRAGMENT_CSS_CLASS = "fragmentCssClass"; | ||
|
|
There was a problem hiding this comment.
These PN_-s would better be public like ProductList.PN_SHOW_IMAGE and NN_FRAGMENTS.
LSantha
reviewed
Jul 7, 2022
...va/com/adobe/cq/commerce/core/components/internal/models/v1/productlist/ProductListImpl.java
Show resolved
Hide resolved
laurentiumagureanu
requested review from
LSantha and
buuhuu
and removed request for
buuhuu
buuhuu
reviewed
Jul 13, 2022
...va/com/adobe/cq/commerce/core/components/internal/models/v1/productlist/ProductListImpl.java
Show resolved
Hide resolved
...com/adobe/cq/commerce/core/components/models/common/CommerceExperienceFragmentContainer.java
Outdated
Show resolved
Hide resolved
...com/adobe/cq/commerce/core/components/models/common/CommerceExperienceFragmentContainer.java
Outdated
Show resolved
Hide resolved
...com/adobe/cq/commerce/core/components/models/common/CommerceExperienceFragmentContainer.java
Outdated
Show resolved
Hide resolved
buuhuu
approved these changes
Jul 13, 2022
buuhuu
reviewed
Jul 13, 2022
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~*/--> | ||
| <template data-sly-template.item="${@ item}"> | ||
| <span class="${'productcollection__item-xf {0}' @ format=[item.cssClassName], context='text'}"> | ||
| <sly data-sly-resource="${item.renderResource}" /> |
There was a problem hiding this comment.
We should include the resource with wcmmode disable. Currently the synthetic resource gets an edit overlay.
buuhuu
reviewed
Jul 13, 2022
| composite="{Boolean}true" | ||
| fieldDescription="Allows insertion of Experience Fragments at specified positions" | ||
| fieldLabel="Experince Fragment placeholders"> | ||
| <field |
There was a problem hiding this comment.
Do you miss the render condition here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
be able to insert an XF into the product list component to show content between products
Related Issue
CIF-2827
Motivation and Context
be able to insert an XF into the product list component to show content between products
How Has This Been Tested?
Unit tests.
Manually
Screenshots (if appropriate):
Types of changes
Checklist: