Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2673 - Add navRoot checkbox to page properties #942

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Conversation

herzog31
Copy link
Member

Description

  • Added Landing Page checkbox to properties page of CIF page component (v1, v2 and v3).
  • Added ShowNavRootRenderConditionServlet to show checkbox only on pages that are either the landing page or don't have a landing page in the hierarchy.
  • Added unit tests.

How Has This Been Tested?

  • UI tests in Venia

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #942 (f630dcd) into master (9c0a815) will decrease coverage by 0.00%.
The diff coverage is 84.61%.

@@             Coverage Diff              @@
##             master     #942      +/-   ##
============================================
- Coverage     89.72%   89.71%   -0.01%     
- Complexity     2148     2154       +6     
============================================
  Files           346      347       +1     
  Lines          9660     9673      +13     
  Branches       1391     1394       +3     
============================================
+ Hits           8667     8678      +11     
- Misses          712      713       +1     
- Partials        281      282       +1     
Flag Coverage Δ
integration 52.28% <61.53%> (+0.03%) ⬆️
jest 86.55% <ø> (ø)
karma 95.33% <ø> (ø)
unittests 88.79% <84.61%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...al/servlets/ShowNavRootRenderConditionServlet.java 84.61% <84.61%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c0a815...f630dcd. Read the comment docs.

@buuhuu buuhuu merged commit d6ed0ba into master Jul 14, 2022
@buuhuu buuhuu deleted the issue/CIF-2673 branch July 14, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants