Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace key/common metadata from the challenger, add a config option for which metadata is updated #23

Open
shsteimer opened this issue May 7, 2024 · 0 comments · Fixed by #24

Comments

@shsteimer
Copy link

This is a very similar issue as #15 but running into an issue with a customer trying to use this where the Template metadata is used to load dynamic js and their challengers are using different template values.

I think we could safely:

  • add a config which is an array of metadata fields to update
  • default that value to be ['template', 'theme']
  • update/overwrite those metadata fields when overwriting main
@shsteimer shsteimer changed the title Auto replace key/common metadata from the challenger, add a config option for which metadata is updated Replace key/common metadata from the challenger, add a config option for which metadata is updated May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant