Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update metadata fields from the challenger content #24

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

shsteimer
Copy link

@shsteimer shsteimer commented May 7, 2024

Description

Related Issue

Fix #23

Motivation and Context

How Has This Been Tested?

Tested with a customer on their live website where they were relying on the template meta property for how things rendered.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@@ -14,6 +14,7 @@ const MAX_SAMPLING_RATE = 10; // At a maximum we sample 1 in 10 requests
export const DEFAULT_OPTIONS = {
// Generic properties
rumSamplingRate: MAX_SAMPLING_RATE, // 1 in 10 requests
overrideMetaFields: [],
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered defaulting this to ['template', 'theme'] but reverted to empty to avoid this being a breaking change. If we aren't concerned about a breaking change, I think the list above is reasonably safe and should cover most cases where metadata affects rendering of the page

@shsteimer shsteimer marked this pull request as ready for review May 8, 2024 16:05
@ramboz ramboz changed the base branch from main to commerce December 6, 2024 16:53
@ramboz ramboz merged commit d5dee33 into adobe:commerce Dec 6, 2024
2 checks passed
@ramboz
Copy link
Contributor

ramboz commented Dec 6, 2024

@shsteimer Thanks for the contribution! We've started having use cases around the Commerce Boilerplate for this, so merged it on our end in a dedicated branch they can use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace key/common metadata from the challenger, add a config option for which metadata is updated
2 participants