feat: predefine loading of sampleRUM.enhance() #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adobe-bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
# [2.7.0](v2.6.1...v2.7.0) (2024-10-17) ### Features * predefine loading of sampleRUM.enhance() ([#105](#105)) ([859ff60](859ff60))
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current setup, the project requires to call
sampleRUM.enhance()in order for the enhancer to get loaded. If the line disappears or is forgotten, enhancer is never loaded. Moving call in the lib would solve that problem.Compared to current implementation, this moves the enhancer loading slightly later (after async font loading) which should not change anything.