feat: add minimal plugin system #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramboz
commented
Oct 27, 2023
| ? id.split('/').splice(id.endsWith('/') ? -2 : -1, 1)[0].replace(/\.js/, '') | ||
| : id; | ||
| const pluginConfig = { | ||
| load: 'eager', |
There was a problem hiding this comment.
Plugins would load in the eager phase by default. should we set this to lazy so we keep the best performance by default, and require explicit opt-in to eager for those plugins that would need immediate instrumentation?
|
Closing in favor of adobe/aem-boilerplate#374 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a minimal plugin/template loading system that can hook into the various ELD phases.
Description
See adobe/aem-boilerplate#254 for full details
How Has This Been Tested?
TBD: petplace, bamboohr, aem.live
Types of changes
Checklist: