Skip to content

Commit

Permalink
fix: rename defaultPlugin to corePlugin
Browse files Browse the repository at this point in the history
  • Loading branch information
dylandepass committed Mar 1, 2024
1 parent 2b42e57 commit 8f5b8e8
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/extension/app/store/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -260,12 +260,12 @@ export class AppStore {
},
container: containerId,
};
// check default plugin
const defaultPlugin = this.corePlugins[plugin.id];
if (defaultPlugin) {
// check if this overlaps with a core plugin, if so override the condition only
const corePlugin = this.corePlugins[plugin.id];
if (corePlugin) {
// extend default condition
const { condition: defaultCondition } = defaultPlugin;
defaultPlugin.condition = (s) => defaultCondition(s) && condition(s);
const { condition: defaultCondition } = corePlugin;
corePlugin.condition = (s) => defaultCondition(s) && condition(s);

Check warning on line 268 in src/extension/app/store/app.js

View check run for this annotation

Codecov / codecov/patch

src/extension/app/store/app.js#L267-L268

Added lines #L267 - L268 were not covered by tests
} else {
// add custom plugin
this.customPlugins[plugin.id] = plugin;
Expand Down

0 comments on commit 8f5b8e8

Please sign in to comment.