Remove semaphore from PersistentHitQueue #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbenedicadb
approved these changes
Jun 4, 2024
cdhoffmann
approved these changes
Jun 4, 2024
| @@ -18,7 +18,7 @@ public class PersistentHitQueue: HitQueuing { | |||
|
|
|||
| private var suspended = true | |||
| private var isTaskScheduled = false | |||
| private let queue = DispatchQueue(label: "com.adobe.mobile.persistenthitqueue") | |||
There was a problem hiding this comment.
nit: it looks like we are using the mobile identifier in a few other places. Do we want to remove it from all of those as well?
There was a problem hiding this comment.
Yes, I will update them separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DispatchSemaphore was initially used to block the async queue until a hit was processed by the hit processor, ensuring sequential handling. However, this caused unnecessary thread creation, especially during app launch when multiple extensions send hits.
This semaphore became redundant once we started using the
isTaskScheduledvariable to guard theprocessNextHitmethod. TheisTaskScheduledvariable ensures new hits will not be processed until the current hit is completed or retried.Also updated the completion logic to access all internal state using the internal queue to avoid race conditions especially when updating
isTaskScheduled.