[MOB-21202]Add extension name to operation orderer tag for debugging #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveek
reviewed
Jun 21, 2024
| @@ -61,7 +61,7 @@ class ExtensionContainer { | |||
| init(_ name: String, _ type: Extension.Type, _ queue: DispatchQueue, completion: @escaping (EventHubError?) -> Void) { | |||
| extensionQueue = queue | |||
| containerQueue = DispatchQueue(label: "\(name).containerQueue") | |||
| eventOrderer = OperationOrderer<Event>() | |||
| eventOrderer = OperationOrderer<Event>(String(describing: type)) | |||
There was a problem hiding this comment.
Can you use "(name).operationOrderer"
There was a problem hiding this comment.
I tested that:
name = "com.adobe.eventhub.extension.AEPCore.Configuration"
String(describing: type) = "Configuration"
I'm ok with either, but thought just having the name of the extension only would be cleaner.
There was a problem hiding this comment.
For the sake of consistency with the previous line, we can reuse the name variable. If we decide to change, we need to use a consistent name for extensionQueue, containerQueue, and operationOrderer, preferably with a com.adobe prefix..
praveek
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at the crash reports for the ticket, i noticed that every operation orderer we create in our extension containers is anonymous. This will name each one with the extension name to help with debugging.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: