-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set parent ID to Edge response events (resolves #327) #361
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #361 +/- ##
==========================================
+ Coverage 96.68% 96.70% +0.02%
==========================================
Files 27 27
Lines 1626 1634 +8
==========================================
+ Hits 1572 1580 +8
Misses 54 54 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some minor comments
if let requestParentEvent = requestParentEvent { | ||
|
||
if let requestParentEvent = parentRequestEvent { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: parentRequestEvent
Description
Add event stitching (chaining) support by setting the Event.parentId to the Event.id of the triggering event.
Event.createResponseEvent()
API already sets the parent ID so no code changes were required. Test cases were added, however.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: