Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-16019] Set pending state before updating IdentityMap #57

Merged
merged 5 commits into from
Mar 28, 2022

Conversation

addb
Copy link
Collaborator

@addb addb commented Mar 17, 2022

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@addb addb requested review from emdobrin and kevinlind March 17, 2022 20:29
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #57 (0b13899) into dev (a9971d7) will increase coverage by 0.33%.
The diff coverage is 92.86%.

@@            Coverage Diff             @@
##              dev      #57      +/-   ##
==========================================
+ Coverage   94.74%   95.07%   +0.33%     
==========================================
  Files           6        6              
  Lines         304      304              
==========================================
+ Hits          288      289       +1     
+ Misses         16       15       -1     

Sources/IdentityState.swift Show resolved Hide resolved
Sources/IdentityState.swift Show resolved Hide resolved
…eCustomerIdentifers or removeCustomerIdentifers are called.
@kevinlind
Copy link
Contributor

We should also add a pending state when resetIdentifiers is called as well as it updates the Identity Map and generates a new ECID.

Tests/UnitTests/IdentityStateTests.swift Show resolved Hide resolved
Sources/Identity.swift Outdated Show resolved Hide resolved
@addb addb merged commit b3efe07 into adobe:dev Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants