Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed timer logic + refactored getCurrentTimeStamp() to return in seconds #23

Merged
merged 1 commit into from
May 4, 2023
Merged

Fixed timer logic + refactored getCurrentTimeStamp() to return in seconds #23

merged 1 commit into from
May 4, 2023

Conversation

addb
Copy link
Contributor

@addb addb commented May 3, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@addb
Updated timer logic. Also refactored getTimestamp() to return in seco…
4c63c17 
…nds to align with the change of ts data type to TimeInterval
@addb addb requested a review from kevinlind May 3, 2023 20:13
@addb addb linked an issue May 3, 2023 that may be closed by this pull request
Fix the internal timer logic #20
Closed
@addb addb merged commit d4e882d into adobe:dev May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlind kevinlind kevinlind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the internal timer logic
2 participants
@addb @kevinlind