Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to node 20 #53

Merged
merged 3 commits into from
Feb 8, 2024
Merged

chore: update to node 20 #53

merged 3 commits into from
Feb 8, 2024

Conversation

MichaelGoberling
Copy link
Contributor

@MichaelGoberling MichaelGoberling commented Feb 7, 2024

Description

Node 16 planned to be deprecated by Spring, GitHub advises to update to Node 20

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Related Issue

Motivation and Context

How Has This Been Tested?

Successful node 20 run using the action

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (886f9a4) 100.00% compared to head (7fc41bc) 100.00%.
Report is 1 commits behind head on master.

❗ Current head 7fc41bc differs from pull request most recent head 6b6204c. Consider uploading reports for the commit 6b6204c to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          107       107           
  Branches        20        20           
=========================================
  Hits           107       107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelGoberling MichaelGoberling merged commit cc2ce31 into master Feb 8, 2024
5 checks passed
@MichaelGoberling MichaelGoberling deleted the node-20 branch February 8, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants