Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major: add schema support #21

Merged
merged 13 commits into from
Jun 7, 2023
Merged

major: add schema support #21

merged 13 commits into from
Jun 7, 2023

Conversation

moritzraho
Copy link
Member

@moritzraho moritzraho commented May 16, 2023

Description

This is a breaking change: validation + new export signature

Kept for later:

  • Add action names/packages field limits
  • Add events required fields, additionalProperties=false + limit/validations
  • schema and typescript definition for the output object
  • autocompletion with schema?

Related Issue

#11

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #21 (643de97) into master (ca93bf4) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 643de97 differs from pull request most recent head ba636bb. Consider uploading reports for the commit ba636bb to get more accurate results

@@            Coverage Diff            @@
##            master       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          226       243   +17     
  Branches        65        69    +4     
=========================================
+ Hits           226       243   +17     
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@moritzraho moritzraho marked this pull request as ready for review June 1, 2023 16:19
@MichaelGoberling MichaelGoberling self-requested a review June 2, 2023 13:07
Copy link
Contributor

@MichaelGoberling MichaelGoberling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Q: Do we need to add the operations key that can be found in ext.config.yaml?

@moritzraho
Copy link
Member Author

good point, done!

Could you give another review? I have moved configSchema to the top level and added a validation for events as well

@moritzraho moritzraho merged commit b248a69 into master Jun 7, 2023
@moritzraho moritzraho deleted the add-schema branch June 7, 2023 08:04
@moritzraho moritzraho changed the title feat: add schema support major: add schema support Jul 4, 2023
@purplecabbage
Copy link
Member

This should have had more discussion, I think this is a mistake to implement this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants