-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
major: add schema support #21
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 226 243 +17
Branches 65 69 +4
=========================================
+ Hits 226 243 +17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Q: Do we need to add the operations
key that can be found in ext.config.yaml
?
good point, done! Could you give another review? I have moved |
This should have had more discussion, I think this is a mistake to implement this here. |
Description
This is a breaking change: validation + new export signature
{ load, validateAppConfig, coalesceAppConfig }
vs previous load functionapp.config.yaml
(taken & modified from https://github.com/adobe/aio-cli-plugin-app/blob/master/schema/app.config.yaml.schema.json)$includes
into one json before validation. Resolve path config values.configSchema
(top level config)web
cdn config.events
Kept for later:
Related Issue
#11
Types of changes
Checklist: