-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACNA- 1833 | Implementing external workflows #9
ACNA- 1833 | Implementing external workflows #9
Conversation
Same comments as the app plugin PR, recent runs of these jobs are failing. Should have them passing before we merge. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 260 260
Branches 80 80
=========================================
Hits 260 260 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, however, there might be benefit in actually publishing these shared workflows. This is something we should discuss
.github/workflows/daily.yml
Outdated
SLACK_MESSAGE: ${{ matrix.node-version }} | ||
SLACK_COLOR: ${{ job.status == 'success' && 'good' || job.status == 'cancelled' && '#808080' || 'danger' }} | ||
|
||
# if: github.repository == 'adobe/aio-cli-lib-app-config' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should keep this line, otherwise these actions will run everyday on every fork ( and fail )
Also, have a look here: https://github.com/adobe/.github/tree/91ba8f2c7a4fe1178181a93b5c0186c285b43f1c/workflow-templates |
@amulyakashyap09 Is this PR still needed? Seems external workflows were already added with #33 |
We don't need this PR anymore. Seems external workflows were already added with #33 |
We don't need this PR anymore. Seems external workflows were already added with #33. closing the PR now. |
Description
Implement reusable github workflows
Related Issue
ACNA-1833
Motivation and Context
Code Reusability
Avoiding Redundancy
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: