Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leverage enhanced ims context handling #97

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

jsedding
Copy link
Collaborator

Description

Change leveraging enhanced IMS context handling implemented in adobe/aio-lib-ims#150. This is currently only a draft, because it requires a new version of aio-lib-ims to be released and set on this PR.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@RemoLiechti RemoLiechti marked this pull request as ready for review October 16, 2024 13:09
Copy link
Collaborator

@RemoLiechti RemoLiechti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests are now all fixed, thanks

@RemoLiechti RemoLiechti merged commit f6fb81e into main Oct 16, 2024
3 checks passed
@RemoLiechti RemoLiechti deleted the cod18017/enhanced-ims-context-handling branch October 16, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AccessToken is always stored in global config below the IMS context Support "imsContextName" parameter
2 participants