feat: ACNA-1602 - add new flag to prevent action code deployment

[arjuncooliitr]

Description

--[no-]action-code flag added to the aio-cli-plugin-app deploy command to prevent action code deployment

Pre-requisite

• feat: ACNA-1602 - add logic for --no-action-code and add options object as a param  aio-lib-runtime#98

Related Issue

Closes #538

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[shazron]

see threaded comments for changes

[shazron]

@arjuncooliitr 1 unit test failure - can you fix so we can add this for a potential Monday release?

[codecov]

Codecov Report

Merging #537 (8edab56) into master (70b9a42) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #537   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           53        53           
  Lines         2812      2813    +1     
  Branches       527       527           
=========================================
+ Hits          2812      2813    +1     

Impacted Files	Coverage Δ
src/commands/app/deploy.js	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[purplecabbage]

It looks like it, but can you verify that these are supported?

Update the params for action1 only ( assume there are many actions in the project )
aio app deploy --no-web-assets -a action1 --no-action-code

Update the params and deploy action1 only ( many actions in project )
aio app deploy --no-web-assets -a action1

[arjuncooliitr]

I tried to verify using a test app builder app having 2 actions. Say action1 and action2.
Behavior of the command is as follows:

aio app deploy --no-web-assets -a action1
=> Deploys only action1 with params and code
aio app deploy --no-web-assets -a action1 --no-action-code
=> Deploys only action1 with params (doesn't pick up action code changes)

So, I think it works as desired

[shazron]

Update: We are still looking over semantics. Discussion and final decision needed before merging.

[shazron]

@arjuncooliitr can you fix up the conflict? thanks!

[arjuncooliitr]

@purplecabbage Sorry this has been long overdue 😅 but you mentioned long back that you had some thoughts regarding the semantics of this flag, so we didn't merge and kept it on hold.
What are your thoughts now? If it looks okay to you then we can proceed and merge.

[arjuncooliitr]

@shazron, resolved the conflict thanks!

[shazron]

@arjuncooliitr can you resolve the new conflict?
@purplecabbage please see Arjun's comments above so this can be resolved.

[purplecabbage]

This is being closed in favor of updated documentation. This pull request was well implemented, however the convenience was deemed to potentially lead to developers overwriting actions as the command syntax was awkward.
The command aio runtime action update --param is expected to be used instead of surfacing the command as an additional flag on aio app deploy