Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aio app pack fixes #702

Merged
merged 8 commits into from
Aug 8, 2023
Merged

aio app pack fixes #702

merged 8 commits into from
Aug 8, 2023

Conversation

moritzraho
Copy link
Member

Description

fix for #697

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@moritzraho moritzraho requested a review from shazron July 26, 2023 13:22
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #702 (d17c009) into master (a7189d4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #702   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3152      3167   +15     
  Branches       589       596    +7     
=========================================
+ Hits          3152      3167   +15     
Files Changed Coverage Δ
src/commands/app/pack.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/commands/app/pack.js Outdated Show resolved Hide resolved
src/commands/app/pack.js Outdated Show resolved Hide resolved
@moritzraho moritzraho merged commit 2b07a9a into master Aug 8, 2023
@moritzraho moritzraho deleted the app-pack-fixes branch August 8, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants