ACNA-2443: partial lib app config update for install and pack #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moritzraho
commented
Sep 4, 2023
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 57
Lines 3199 3207 +8
Branches 604 605 +1
=========================================
+ Hits 3199 3207 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@moritzraho conflicts that can't be resolved via Github UI |
…hema-for-install-and-pack
shazron
reviewed
Sep 7, 2023
moritzraho
force-pushed
the
ACNA-2443/update-schema-for-install-and-pack
branch
from
11a5b3f to
ed50ebb
Compare
shazron
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE this is only a partial update because
app packandapp installneed to validate the user configuration against a schema. The schema tracked in app plugin is outdated and the current validation logic doesn't resolve $included files.The schema and validation logic is now part of app config lib.
A reason to not yet do a full update is to avoid validating the schema on every command before we expose the schema version to the config or at least support a no validation option. This requires further discussion with the team.
Related Issue
#709
deferred related PR #682
Types of changes
Checklist: