Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[workspace:select][workspace:download] constants should be in the superclass #119

Closed
shazron opened this issue May 15, 2020 · 2 comments · Fixed by #132
Closed

[workspace:select][workspace:download] constants should be in the superclass #119

shazron opened this issue May 15, 2020 · 2 comments · Fixed by #132
Assignees
@purplecabbage
Labels
enhancement New feature or request

Comments

@shazron
Copy link
Member

shazron commented May 15, 2020 •
edited
Loading 

const ORG_KEY = 'org'
const PROJECT_KEY = 'project'
const WORKSPACE_KEY = 'workspace'

so they can be reused by the other select commands as well as this command
This was referenced May 15, 2020
Closed
Closed
@shazron shazron changed the title [workspace:select] constants should be in the superclass [workspace:select][workspace:download] constants should be in the superclass May 15, 2020
@meryllblanchet meryllblanchet added the enhancement New feature or request label May 15, 2020
@meryllblanchet
Copy link
Contributor

@sandeep-paliwal could you have a look?

purplecabbage added a commit to purplecabbage/aio-cli-plugin-console that referenced this issue May 15, 2020
@purplecabbage
select org clears project+workspace, select project clears workspace,…
1bcac91 
… config key constants. Closes adobe#128. Closes adobe#119. Closes adobe#120. Closes adobe#121.
@purplecabbage purplecabbage mentioned this issue May 15, 2020
Merged
10 tasks
@sandeep-paliwal
Copy link
Contributor

Added PR - #133

shazron pushed a commit that referenced this issue May 15, 2020
@purplecabbage
select org clears project+workspace, select project clears workspace,…
d262738 
… config key constants. Closes #128. Closes #119. Closes #120. Closes #121. (#132)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@purplecabbage purplecabbage

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
4 participants
@shazron @purplecabbage @meryllblanchet @sandeep-paliwal