Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AIO_CLI_ENV=stage aio console:org:list always uses prod env #162

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

shazron
Copy link
Member

@shazron shazron commented Jun 22, 2021

fixes #159

How Has This Been Tested?

npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #162 (f269de6) into master (c7ca60c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #162   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          355       353    -2     
  Branches        40        39    -1     
=========================================
- Hits           355       353    -2     
Impacted Files Coverage Δ
src/config.js 100.00% <ø> (ø)
src/commands/console/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7ca60c...f269de6. Read the comment docs.

Copy link
Contributor

@sandeep-paliwal sandeep-paliwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shazron shazron merged commit 4916e19 into master Jun 23, 2021
@shazron shazron deleted the cli-env branch June 23, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIO_CLI_ENV=stage aio console:org:list always uses prod env
2 participants