Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @adobe/aio-lib-ims will require node-12 or greater starting July 14th, 2021 #164

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

shazron
Copy link
Member

@shazron shazron commented Aug 6, 2021

Fixes #163

How Has This Been Tested?

npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #164 (cf32450) into master (e85b9aa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #164   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          353       353           
  Branches        39        39           
=========================================
  Hits           353       353           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e85b9aa...cf32450. Read the comment docs.

@shazron shazron merged commit 667df27 into master Aug 10, 2021
@shazron shazron deleted the node-12-engine branch August 10, 2021 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@adobe/aio-lib-ims will require node-12 or greater starting July 14th, 2021
1 participant