Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-1394 - does not spawn browser for login when it is unauthenticated #170

Merged
merged 2 commits into from
Jan 15, 2022

Conversation

shazron
Copy link
Member

@shazron shazron commented Dec 9, 2021

Closes #168

How Has This Been Tested?

aio logout -f first before each command.

  1. aio console org list
  2. AIO_CLI_ENV=stage aio console org list

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #170 (9619ed0) into master (c2a0895) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #170   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          356       357    +1     
  Branches        42        42           
=========================================
+ Hits           356       357    +1     
Impacted Files Coverage Δ
src/commands/console/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2a0895...9619ed0. Read the comment docs.

@shazron shazron merged commit 31fe67f into master Jan 15, 2022
@shazron shazron deleted the login-fix branch January 15, 2022 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

does not spawn browser for login when it is unauthenticated
2 participants