Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat. Oclif v2 migration #171

Merged
merged 3 commits into from
Jun 20, 2022
Merged

feat. Oclif v2 migration #171

merged 3 commits into from
Jun 20, 2022

Conversation

florind-ens
Copy link
Contributor

@florind-ens florind-ens commented Mar 2, 2022

Description

Migrating to @oclif/core from the old oclif libraries, according to Oclif v2 migration guide: https://github.com/oclif/core/blob/main/MIGRATION.md

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@florind-ens florind-ens requested a review from shazron March 2, 2022 10:29
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #171 (98f7e0a) into master (95c9431) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #171   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          524       519    -5     
  Branches        75        75           
=========================================
- Hits           524       519    -5     
Impacted Files Coverage Δ
src/commands/console/index.js 100.00% <100.00%> (ø)
src/commands/console/org/index.js 100.00% <100.00%> (ø)
src/commands/console/org/list.js 100.00% <100.00%> (ø)
src/commands/console/org/select.js 100.00% <100.00%> (ø)
src/commands/console/project/index.js 100.00% <100.00%> (ø)
src/commands/console/project/list.js 100.00% <100.00%> (ø)
src/commands/console/project/select.js 100.00% <100.00%> (ø)
src/commands/console/publickey/delete.js 100.00% <100.00%> (ø)
src/commands/console/publickey/index.js 100.00% <100.00%> (ø)
src/commands/console/publickey/list.js 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c9431...98f7e0a. Read the comment docs.

@purplecabbage purplecabbage merged commit 21cf522 into master Jun 20, 2022
@purplecabbage purplecabbage deleted the ocliv-v2-migration branch June 20, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants