Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update deploy and gh-pages workflow #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: Update deploy and gh-pages workflow #14

wants to merge 3 commits into from

Conversation

icaraps
Copy link
Contributor

@icaraps icaraps commented Apr 13, 2021 •
edited
Loading

  • Reverted incremental build because of plugin issues
  • Added Fastly cache purge
  • Fixed zombie pages
  • PATH_PREFIX is read from the gatsby-config file
  • Added gdocs support
  • Renamed GATSBY_LAUNCH to ADOBE_LAUNCH
  • Uses org secrets prefixed with AIO_
  • Deleted pr-approved workflow

@icaraps
feat: Update deploy and gh-pages workflow
a25c5af 
* Reverted incremental build because of plugin issues
* Added Fastly cache purge
* Fixed zombie pages
* PATH_PREFIX is read from the gatsby-config file
* Added gdocs support
* Renamed GATSBY_LAUNCH to ADOBE_LAUNCH
* Uses org secrets prefixed with AIO_
* Deleted pr-approved workflow
@icaraps icaraps requested a review from shazron April 13, 2021 16:27
@codecov
Copy link

codecov bot commented Apr 13, 2021 •
edited
Loading

Codecov Report

Merging #14 (eea79e4) into master (23013fe) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           68        68           
  Branches         6         6           
=========================================
  Hits            68        68

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

shazron
shazron approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@shazron shazron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a breaking change so we need to up the major version:

  1. No pr approved process now
  2. org secrets now prefixed by AIO_
  3. No PATH_PREFIX since it's now set in gatsby_config.js

@icaraps
Copy link
Contributor Author

icaraps commented Apr 15, 2021

Ok I've updated all sites with the new workflows

@shazron shazron mentioned this pull request Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shazron shazron shazron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icaraps @shazron