Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade @oclif/plugin-help to ^2.2.3 #28

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Conversation

shazron
Copy link
Member

@shazron shazron commented Mar 11, 2022

The help plugin, or one of its sub-dependencies, is breaking the tests in node-16 (since 7 days ago: see Actions tab daily tests which uses node-16). Tests pass on node-14. It's possible that the help plugin on v3+ does not work on node-16. Downgrading the plugin to v2 fixes this.

Closes #27

How Has This Been Tested?

  1. npm test
  2. linking the plugin at this branch and running aio event does not show the TypeError: Help is not a constructor error

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #28 (7a1baac) into master (99b7b5a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          483       499   +16     
  Branches        48        64   +16     
=========================================
+ Hits           483       499   +16     
Impacted Files Coverage Δ
src/commands/event/provider/get.js 100.00% <0.00%> (ø)
src/commands/event/provider/list.js 100.00% <0.00%> (ø)
src/commands/event/provider/create.js 100.00% <0.00%> (ø)
src/commands/event/provider/delete.js 100.00% <0.00%> (ø)
src/commands/event/provider/update.js 100.00% <0.00%> (ø)
src/commands/event/registration/get.js 100.00% <0.00%> (ø)
src/commands/event/eventmetadata/get.js 100.00% <0.00%> (ø)
src/commands/event/registration/list.js 100.00% <0.00%> (ø)
src/commands/event/eventmetadata/list.js 100.00% <0.00%> (ø)
src/commands/event/registration/create.js 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99b7b5a...7a1baac. Read the comment docs.

Copy link
Contributor

@fe-lix- fe-lix- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works.

@shazron shazron merged commit b7d8bbd into master Mar 14, 2022
@shazron shazron deleted the help-prototype-fix branch March 14, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Help is not a constructor on all event command.
2 participants