Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aio-lib-events version and use registration V2 API #48

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

sangeetha5491
Copy link
Contributor

@sangeetha5491 sangeetha5491 commented Apr 7, 2023

Update aio-lib-events version to 3.0.0

Description

Use the latest SDK to use Registration V2 API

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #48 (aac2f98) into master (ac2e697) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #48   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          488       488           
  Branches        64        64           
=========================================
  Hits           488       488           
Impacted Files Coverage Δ
src/commands/event/registration/create.js 100.00% <100.00%> (ø)
src/commands/event/registration/delete.js 100.00% <100.00%> (ø)
src/commands/event/registration/get.js 100.00% <100.00%> (ø)
src/commands/event/registration/index.js 100.00% <100.00%> (ø)
src/commands/event/registration/list.js 100.00% <100.00%> (ø)
test/mocks.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@shikhartanwar shikhartanwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well!

@sangeetha5491 sangeetha5491 merged commit 60a72ea into master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants