Fix difference between integration types and corresponding json keys #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 15, 2023 16:28
- For integration_type: 'service', console stores the credential config corresponding to 'jwt' key - For integration_type: 'oauth_server_to_server', console stores the credential config corresponding to 'oauth_server_to_server' key - For integration_type: 'oauth_server_to_server_migrate', console has both 'jwt' and 'oauth_server_to_server` credentials but we fetch details from 'oauth_server_to_server' key
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 498 499 +1
Branches 68 65 -3
=========================================
+ Hits 498 499 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the difference between integration types and corresponding json keys in Console's project config:
service, console stores the credential config corresponding tojwtkeyoauth_server_to_server, console stores the credential config corresponding tooauth_server_to_serverkeyoauth_server_to_server_migrate, console has bothjwtandoauth_server_to_servercredentials but we fetch details fromoauth_server_to_serverkeyRelated Issue
Motivation and Context
How Has This Been Tested?
npm run testaio event provider listcommand for all 3 types of project:Screenshots (if appropriate):
Types of changes
Checklist: