Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACNA-1833 | Externalising github workflow #91

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

amulyakashyap09
Copy link
Contributor

Description

Implement reusable github workflows

Related Issue

ACNA-1833

Motivation and Context

  • Code Reusability
  • Avoiding Redundancy

How Has This Been Tested?

  • This will be tested after PR is merged and deployed.
  • This is workflow changes can only be tested post merge.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required checks has changed because of the reuseable workflows - I changed them in the Settings so now all pass

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a08acc8) 100.00% compared to head (34c9092) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #91   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          730       730           
  Branches       104       104           
=========================================
  Hits           730       730           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shazron shazron merged commit 7be7c1d into master Feb 2, 2024
7 checks passed
@shazron shazron deleted the feature/externalising-github-workflows branch February 2, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants