Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display proxy urls #28

Merged
merged 5 commits into from
Oct 6, 2021
Merged

feat: display proxy urls #28

merged 5 commits into from
Oct 6, 2021

Conversation

shazron
Copy link
Member

@shazron shazron commented Sep 28, 2021

Fixes #30

via HTTP_PROXY, HTTPS_PROXY environment variables.

How Has This Been Tested?

.bin/run info
HTTP_PROXY=http://foo.bar .bin/run info
HTTPS_PROXY=https://bar.foo .bin/run info
HTTP_PROXY=http://foo.bar HTTPS_PROXY=https://bar.foo .bin/run info

Screenshots (if appropriate):

Not set:
Screen Shot 2021-09-28 at 3 46 09 PM

Proxies set:
Screen Shot 2021-09-28 at 3 45 55 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

HTTP_PROXY, HTTPS_PROXY environment variables.
@shazron shazron marked this pull request as ready for review September 28, 2021 08:08
@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #28 (289c986) into master (d6b647c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           74        82    +8     
  Branches        12        14    +2     
=========================================
+ Hits            74        82    +8     
Impacted Files Coverage Δ
src/commands/info.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6b647c...289c986. Read the comment docs.

@shazron shazron marked this pull request as draft September 29, 2021 09:43
@shazron shazron closed this Sep 29, 2021
@shazron shazron reopened this Sep 29, 2021
@shazron shazron marked this pull request as ready for review October 6, 2021 04:18
@shazron shazron merged commit f985012 into master Oct 6, 2021
@shazron shazron deleted the proxy-support branch October 6, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add proxy info support
2 participants