Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak missing property messages to improve clarity #107

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

DrewML
Copy link
Contributor

@DrewML DrewML commented Feb 5, 2020

Description

Hey! Still learning I/O ins and outs, and went to copy some config in manifest.yml to create a second function for my application.

Unfortunately I missed some fields, specifically the runtime field. The following error message was flushed when running aio app deploy:

Error: Invalid or missing runtime in the manifest for this action: store-locator-extension-0.0.1/graphql

When I read this message, I was thinking of runtime more as an Adobe concept, and it didn't immediately occur to me that runtime was a property name.

Tweaked two error messages to (hopefully) add some clarity.

Related Issue

Motivation and Context

Easier onboarding for new folks

How Has This Been Tested?

Functionality is already covered by unit tests, just updated the error string we're asserting on

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #107 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #107   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          57     57           
  Lines        1737   1737           
  Branches      302    302           
=====================================
  Hits         1737   1737
Impacted Files Coverage Δ
src/runtime-helpers.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ca14ee...b79e8f4. Read the comment docs.

@purplecabbage purplecabbage merged commit ac148cc into adobe:master Feb 5, 2020
@DrewML DrewML deleted the tweak-missing-prop-messages branch February 5, 2020 23:45
bhageena pushed a commit to bhageena/aio-cli-plugin-runtime that referenced this pull request Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants