Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only emit rule delete if json flag is given. #113

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

rabbah
Copy link
Contributor

@rabbah rabbah commented Feb 11, 2020

Description

Adds --json to rule delete and emits API response only when flag is present.

Related Issue

Fixes #112.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #113 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #113   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          57     57           
  Lines        1741   1743    +2     
  Branches      303    304    +1     
=====================================
+ Hits         1741   1743    +2
Impacted Files Coverage Δ
src/commands/runtime/rule/delete.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cfcc81...e200ce0. Read the comment docs.

@purplecabbage purplecabbage merged commit de569e0 into adobe:master Feb 12, 2020
@rabbah rabbah deleted the rule-delete branch February 12, 2020 03:14
bhageena pushed a commit to bhageena/aio-cli-plugin-runtime that referenced this pull request Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deleting a rule always emits the API response to console
2 participants