Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit activation id for trigger firing. #124

Merged
merged 2 commits into from
Feb 27, 2020

Conversation

rabbah
Copy link
Contributor

@rabbah rabbah commented Feb 12, 2020

Description

Shows trigger activation id when firing a trigger.

... trigger fire mytrigger
{
  "activationId": "f1f95a6064ed457eb95a6064edf57e78"
}

Related Issue

Fixes #121.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #124 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #124   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         1776      1777    +1     
  Branches       319       319           
=========================================
+ Hits          1776      1777    +1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e43c27...097ec94. Read the comment docs.

@rabbah rabbah force-pushed the trigger-activation-id branch from 6e9ac66 to 56fb642 Compare February 19, 2020 21:54
@purplecabbage purplecabbage merged commit 767cf18 into adobe:master Feb 27, 2020
@rabbah rabbah deleted the trigger-activation-id branch January 25, 2021 17:30
bhageena pushed a commit to bhageena/aio-cli-plugin-runtime that referenced this pull request Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trigger fire should emit activation id
2 participants