Support action create/update with --docker. #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 57 57
Lines 1771 1771
Branches 317 317
=====================================
Hits 1771 1771Continue to review full report at Codecov.
|
ddragosd
reviewed
Feb 12, 2020
| @@ -234,6 +244,9 @@ ActionCreate.flags = { | |||
| sequence: flags.string({ | |||
| description: 'treat ACTION as comma separated sequence of actions to invoke' // help description for flag | |||
| }), | |||
| docker: flags.string({ | |||
| description: 'use provided Docker image (a path on DockerHub) to run the action' // help description for flag | |||
There was a problem hiding this comment.
@rabbah mind insert the word Restricted ! before use provided ... . B/c this feature is not GA, but available to select namespaces only.
|
thanks a lot @rabbah ! Just merged this. |
bhageena
pushed a commit
to bhageena/aio-cli-plugin-runtime
that referenced
this pull request
Jul 21, 2021
Support action create/update with --docker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR supersedes #114 and adds --docker flag for action create/update.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: