Fix issues related to parsing of package name. #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 57
Lines 1833 1847 +14
Branches 334 337 +3
=========================================
+ Hits 1833 1847 +14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
This looks good @rabbah
Can you remove the package.json change to update the openwhisk client dep? this already updated in master.
Action list, package delete/bind/get now properly parse the package name of the format [[/]ns/]pkg. Also fixes --verbose/-v flags on package get.
|
Updated to master. |
bhageena
pushed a commit
to bhageena/aio-cli-plugin-runtime
that referenced
this pull request
Jul 21, 2021
* Fix issues related to parsing of package name. Action list, package delete/bind/get now properly parse the package name of the format [[/]ns/]pkg. Also fixes --verbose/-v flags on package get. * Fix and update package tests. * Fix and update action list tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Closes #123.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: