Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-2593 - support aio -v and aio -h #525

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

shazron
Copy link
Member

@shazron shazron commented Oct 17, 2023

Closes #434

This was in oclif v1, but removed in oclif v2, and can be added with a oclif config change.
This helps with this failure as well: https://github.com/adobe/aio-cli/actions/runs/6540787580/job/17761310657

I will put up an aio-cli patch release for this as well after.

How Has This Been Tested?

In the patch branch, run:

  • ./bin/run -v
  • ./bin/run -h

Verified that it doesn't work in the master branch.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This was in oclif v1, but removed in oclif v2, and can be added with a oclif config change.
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #525 (793f9e2) into master (09a24af) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #525   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          238       238           
  Branches        47        47           
=========================================
  Hits           238       238           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shazron shazron merged commit 8c7b8d3 into master Oct 17, 2023
7 checks passed
@shazron shazron deleted the story/ACNA-2593 branch October 17, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aio -v is not working
3 participants