Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACNA-1828 | Implementing external workflows #44

Merged

Conversation

amulyakashyap09
Copy link
Contributor

Description

Implement reusable github workflows

Related Issue

ACNA-1828

Motivation and Context

Code Reusability
Avoiding Redundancy

How Has This Been Tested?

  • This will be tested after PR is merged and deployed.
  • This is workflow changes can only be tested post merge.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1695581) 100.00% compared to head (98c7a80) 100.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          505       505           
  Branches        15        15           
=========================================
  Hits           505       505           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shazron
Copy link
Member

shazron commented Aug 15, 2023

closing and re-opening - the checks are not working right.

@shazron shazron closed this Aug 15, 2023
@shazron shazron reopened this Aug 15, 2023
@shazron
Copy link
Member

shazron commented Aug 15, 2023

@amulyakashyap09 I think two different workflows are running at the same time. See the checks

Copy link
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amulyakashyap09 Needs required checks change in Branch protection settings.

@amulyakashyap09 amulyakashyap09 merged commit 83e5638 into master Feb 12, 2024
7 checks passed
@amulyakashyap09 amulyakashyap09 deleted the feature/ACNA-1828-externalize-github-workflows branch February 12, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants