Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issues with jest/no-conditional-expect #55

Closed
shazron opened this issue Aug 18, 2023 · 1 comment · Fixed by #65
Closed

fix issues with jest/no-conditional-expect #55

shazron opened this issue Aug 18, 2023 · 1 comment · Fixed by #65
Labels
bug Something isn't working

Comments

@shazron
Copy link
Member

shazron commented Aug 18, 2023 •
edited
Loading

Search for the text:
eslint-disable-next-line jest/no-conditional-expect

The disabling of these lines were temporary due to the eslint config upgrade. Using conditional expects do hide certain implementation issues or bad/incomplete tests.

index.test.js

  1. Get registration with retries -> Test for retries on 5xx response
  2. Publish event with retries -> Test for retries on 5xx response
  3. Fetch from journalling -> Fetch from journal with retries

signatureUtils.test.js

  1. Test Fetch Key from CloudFront with Invalid Pub Key Url -> verify for invalid pub key
  2. Test Fetch Pem Encoded Public Keys -> verify for invalid pub key url throws
  3. Test Get Key from Cache -> get key from cache throws

See #56, #57, and #58 before updating the tests.
@shazron shazron added the bug Something isn't working label Aug 18, 2023
@aiojbot
Copy link
Collaborator

aiojbot commented Aug 18, 2023

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2496

shazron added a commit that referenced this issue Feb 2, 2024
@shazron
fix: non-breaking implementation changes and proper tests (replaced i…
511c635 
…nvalid tests)

closes #55
closes #56
closes #57
closes #58
@shazron shazron mentioned this issue Feb 2, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@shazron @aiojbot