Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update aio-lib-networking library #34

Merged
merged 11 commits into from
Aug 15, 2023

Conversation

nicdard
Copy link
Contributor

@nicdard nicdard commented Mar 6, 2023

Description

Use new aio-lib-networking library:

  • Use aio-lib-core-networking version 4.1.0
  • HttpBackoffExponential is parsing Retry-After header
  • use new utility parseRetryAfterHeader provided by the library and remove old parseRetryAfterHeader helper

Related Issue

adobe/aio-lib-core-networking#31
https://github.com/adobe/aio-lib-core-networking/pull/22/files

Motivation and Context

Better handling of cases where the server specify a Retry-After header.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nicdard nicdard force-pushed the feat/use-retry-after-header branch from 945e337 to 3ad455a Compare March 21, 2023 11:12
@nicdard
Copy link
Contributor Author

nicdard commented Mar 21, 2023

@sangeetha5491 I update lib-core-networking to the latest one and remove the temporary pointer to a local package in package.json

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #34 (dc64273) into master (f999796) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          422       417    -5     
  Branches        56        55    -1     
=========================================
- Hits           422       417    -5     
Files Changed Coverage Δ
src/helpers.js 100.00% <ø> (ø)
src/index.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shazron shazron requested a review from sangeetha5491 July 12, 2023 02:50
@shazron shazron merged commit bfb5e17 into adobe:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants