Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cli env to determine the URLs #61

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Conversation

sangeetha5491
Copy link
Contributor

@sangeetha5491 sangeetha5491 commented Sep 12, 2023

Description

Use CLI env to determine the use of stage or prod urls

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #61 (cc03b7c) into master (bfb5e17) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #61   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          417       441   +24     
  Branches        55        56    +1     
=========================================
+ Hits           417       441   +24     
Files Changed Coverage Δ
src/index.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shazron
Copy link
Member

shazron commented Sep 12, 2023

set eslint-plugin-n to ^15.7.0 to fix the CI failure

@sandeep-paliwal
Copy link
Contributor

Code changes look good. Approving the PR

@shazron shazron merged commit d087fd5 into adobe:master Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants