Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEXT-2009 Add New Relic support to aio CLI #148

Merged

Conversation

gjmarques
Copy link
Contributor

@gjmarques gjmarques commented Jun 28, 2023

Description

Add New Relic support to log forwarding

Related Issue

Log forwarding New Relic support
Add New Relic support to aio CLI

Motivation and Context

Log Forwarding currently supports Splunk and Azure Log Analytics. This PR adds support for New Relic.

How Has This Been Tested?

Auto tests are included

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

src/LogForwarding.js Outdated Show resolved Hide resolved
test/LogForwarding.test.js Outdated Show resolved Hide resolved
test/LogForwardingUnderscoreNamespace.test.js Outdated Show resolved Hide resolved
@shazron
Copy link
Member

shazron commented Jul 6, 2023

@gjmarques:

  1. The comments above need to be resolved.
  2. The unit tests are failing, can you please check? Thanks!

gjmarques added 2 commits July 6, 2023 10:05
…om:gjmarques/aio-lib-runtime into CEXT-2009-Add-New-Relic-support-to-aio-CLI
@gjmarques
Copy link
Contributor Author

@shazron
Comments above have been resolved and tests seem to be working locally

@shazron
Copy link
Member

shazron commented Jul 7, 2023

@gjmarques eslint failure (see failing test). Should be caught by npm test I think

@gjmarques
Copy link
Contributor Author

@shazron
Linting errors should have been fixed

@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #148 (21e536c) into master (d6d065b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #148   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1316      1316           
  Branches       349       349           
=========================================
  Hits          1316      1316           
Impacted Files Coverage Δ
src/LogForwardingLocalDestinationsProvider.js 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shazron shazron merged commit e5c8fd2 into adobe:master Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants