Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add daily npm install and test workflow #74

Merged
merged 4 commits into from
Sep 29, 2021
Merged

Conversation

sandeep-paliwal
Copy link
Contributor

Add workflow to run daily npm install and unit tests

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #74 (e68bb09) into master (3f402db) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #74   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1083      1083           
  Branches       272       272           
=========================================
  Hits          1083      1083           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f402db...e68bb09. Read the comment docs.

runs-on: ${{ matrix.os }}
strategy:
matrix:
node: [14]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include node 12 as well ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default Runtime uses Node v14 and we are making sure that our npm doesn't break on it for a daily run.
Not sure we need to add more versions to matrix for daily run as long as build and test of PRs and commits includes all supported versions.

@sandeep-paliwal sandeep-paliwal merged commit 4909581 into master Sep 29, 2021
@shazron shazron deleted the daily_npm_install branch October 6, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants