fix: use @adobe/eslint-config-aio-lib-config and fix linting errors

adobe · Dec 14, 2021 · e4d2937 · e4d2937
1 parent 6ac3a13
commit e4d2937
Show file tree

Hide file tree

Showing 4 changed files with 161 additions and 126 deletions.
diff --git a/e2e/e2e.js b/e2e/e2e.js
@@ -16,7 +16,7 @@ const path = require('path')
 // load .env values in the e2e folder, if any
 require('dotenv').config({ path: path.join(__dirname, '.env') })
 
-var sdkClient = {}
+let sdkClient = {}
 const tenant = process.env.TARGET_TENANT
 const apiKey = process.env.TARGET_APIKEY
 const token = process.env.TARGET_TOKEN
@@ -34,7 +34,7 @@ test('sdk init test', async () => {
 })
 
 test('test getActivities and getABActivityById', async () => {
-  var res = await sdkClient.getActivities()
+  let res = await sdkClient.getActivities()
   expect(res.status).toEqual(200)
   if (res.body.total > 0) {
     const activities = res.body.activities
@@ -57,7 +57,7 @@ test('test getActivities and getABActivityById', async () => {
 })
 
 test('test getOffers and getOfferById', async () => {
-  var res = await sdkClient.getOffers()
+  let res = await sdkClient.getOffers()
   expect(res.status).toEqual(200)
   if (res.body.total > 0) {
     const offers = res.body.offers
@@ -75,7 +75,7 @@ test('test getOffers and getOfferById', async () => {
 })
 
 test('test getAudiences and getAudienceById', async () => {
-  var res = await sdkClient.getAudiences()
+  let res = await sdkClient.getAudiences()
   expect(res.status).toEqual(200)
   if (res.body.total > 0) {
     const audiences = res.body.audiences
@@ -88,7 +88,7 @@ test('test getAudiences and getAudienceById', async () => {
 })
 
 test('test getProperties and getPropertyById', async () => {
-  var res = await sdkClient.getProperties()
+  let res = await sdkClient.getProperties()
   expect(res.status).toEqual(200)
   if (res.body.total > 0) {
     const properties = res.body.properties
@@ -100,14 +100,14 @@ test('test getProperties and getPropertyById', async () => {
 })
 
 test('test getMBoxes', async () => {
-  var res = await sdkClient.getMBoxes()
+  const res = await sdkClient.getMBoxes()
   expect(res.status).toEqual(200)
 })
 test('test getMBoxProfileAttributes', async () => {
-  var res = await sdkClient.getMBoxProfileAttributes()
+  const res = await sdkClient.getMBoxProfileAttributes()
   expect(res.status).toEqual(200)
 })
 test('test getEnvironments', async () => {
-  var res = await sdkClient.getEnvironments()
+  const res = await sdkClient.getEnvironments()
   expect(res.status).toEqual(200)
 })
diff --git a/package.json b/package.json
@@ -14,29 +14,30 @@
     "validate": "bin/validate_spec.js spec/target_api.json"
   },
   "dependencies": {
-    "swagger-client": "3.13.5",
     "@adobe/aio-lib-core-errors": "^3.0.0",
-    "@adobe/aio-lib-core-logging": "^1.1.2"
+    "@adobe/aio-lib-core-logging": "^1.1.2",
+    "swagger-client": "3.13.5"
   },
   "devDependencies": {
-    "@adobe/eslint-config-aio-lib-config": "^1.2.0",
+    "@adobe/eslint-config-aio-lib-config": "^1.4.0",
     "codecov": "^3.6.1",
     "dotenv": "^8.1.0",
-    "eslint": "^6.0.0",
-    "eslint-config-standard": "^14.1.1",
-    "eslint-plugin-import": "^2.22.0",
-    "eslint-plugin-jest": "^23.18.0",
-    "eslint-plugin-jsdoc": "^21.0.0",
-    "eslint-plugin-node": "^10.0.0",
-    "eslint-plugin-promise": "^4.2.1",
+    "eslint": "^7.32.0",
+    "eslint-config-standard": "^16.0.3",
+    "eslint-plugin-import": "^2.25.3",
+    "eslint-plugin-jest": "^23.20.0",
+    "eslint-plugin-jsdoc": "^37.2.0",
+    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-promise": "^5.2.0",
     "eslint-plugin-standard": "^5.0.0",
     "fetch-mock": "^9.10.3",
     "jest": "^24.1.0",
     "jest-cli": "^24.8.0",
     "jest-junit": "^10.0.0",
     "jest-plugin-fs": "^2.9.0",
     "jsdoc-to-markdown": "^5.0.0",
-    "openapi-schema-validator": "^3.0.3"
+    "openapi-schema-validator": "^3.0.3",
+    "typescript": "^4.5.4"
   },
   "jest": {
     "testPathIgnorePatterns": [