Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with get calls caused by latest swagger client #53

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

sandeep-paliwal
Copy link
Contributor

@sandeep-paliwal sandeep-paliwal commented Feb 24, 2021

Fixes #52
With new swagger client 3.10.2 get calls were failing for empty body. Fixed this.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

unit tests and e2e test.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #53 (7d5ed88) into master (6aeaf8c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          491       491           
  Branches        76        76           
=========================================
  Hits           491       491           
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aeaf8c...7d5ed88. Read the comment docs.

@shazron shazron merged commit 705b295 into master Feb 24, 2021
@shazron shazron deleted the e2e_issue branch July 9, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target SDK get calls failing with swagger client update
2 participants