Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node 10 required? #11

Closed
shazron opened this issue Jul 26, 2019 · 5 comments · Fixed by #17
Closed

node 10 required? #11

shazron opened this issue Jul 26, 2019 · 5 comments · Fixed by #17

Comments

@shazron
Copy link
Member

shazron commented Jul 26, 2019

This might be an issue since for the CLI, only node 8 is required.
See: https://github.com/adobe/adobeio-cna-scripts/blob/78ac7b9f43592061e7ab9adb94c04bcf857c8a24/package.json#L13
@shazron
Copy link
Member Author

shazron commented Jul 26, 2019 •
edited
Loading

Jesse mentioned that wskdebug requires node 10/12. If so, there is a mismatch with the CLI requirements. We might have to bump the CLI node requirement to 10 for CLI v3.0

@shazron shazron mentioned this issue Jul 29, 2019
Closed
@shazron
Copy link
Member Author

shazron commented Jul 29, 2019

We need to handle this gracefully, because right now if you don't have at least node 10, the install will fail with a non-clear error (see adobe/aio-cli-plugin-app#27)

@shazron
Copy link
Member Author

shazron commented Jul 31, 2019

We should see if the plugins plugin can fail if the node version requirements are not fulfilled: file a bug and/or PR to their repo: https://github.com/oclif/plugin-plugins

@shazron
Copy link
Member Author

shazron commented Jul 31, 2019 •
edited
Loading

Using npx we can install a local version of node specific for running wskdebug? not sure how it will work exactly.

@shazron
Copy link
Member Author

shazron commented Jul 31, 2019

Related: oclif/plugin-plugins#73

@purplecabbage purplecabbage mentioned this issue Aug 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

joi to @hapi/joi, relax node10 requirement
1 participant
@shazron