Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins:add fails silently if yarn fails #73

Closed
dprothero opened this issue May 2, 2019 · 4 comments
Closed

plugins:add fails silently if yarn fails #73

dprothero opened this issue May 2, 2019 · 4 comments

Comments

@dprothero
Copy link

Using this CLI: https://gitub.com/twilio/twilio-cli

running: twilio plugins:add @twilio-labs/plugin-serverless

on a machine with Node less than 8.10 (my use case is 8.9.1) will just fail silently after step 2/4

When I copy and manually run the yarn command that is shown via DEBUG=* I see the issue:

yarn add v1.15.2
[1/4] Resolving packages...
[2/4] Fetching packages...
error @twilio-labs/plugin-serverless@1.0.0-alpha.2: The engine "node" is incompatible with this module. Expected version ">=8.10.0". Got "8.9.1"
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

Expected behavior: I should see the yarn error output instead of nothing when installing a plugin and it fails. Or, at least a "plugin installation failed" and the full details when using DEBUG.

@dprothero
Copy link
Author

Also fails if the plugin cannot be found:

➜  ~ twilio plugins:install lasdjkfiwejfojdslfkjsdlfjie
Installing plugin lasdjkfiwejfojdslfkjsdlfjie... ⣯ [1/4] Resolving packages...
➜  ~

@dprothero
Copy link
Author

@RasPhilCo any thoughts on this one?

@RasPhilCo
Copy link
Contributor

Hey @dprothero, I'm back from PTO. Looks like the error message is getting swallowed if cli.action is running. Will need to investigate further.

@RasPhilCo
Copy link
Contributor

Should be fixed in #195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants