Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Major] remove audience-manager #41

Merged
merged 6 commits into from
Dec 18, 2023
Merged

[Major] remove audience-manager #41

merged 6 commits into from
Dec 18, 2023

Conversation

purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented Jun 28, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (075864c) 100.00% compared to head (4015bd9) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           10         9    -1     
=========================================
- Hits            10         9    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelGoberling MichaelGoberling self-requested a review June 28, 2023 01:34
Copy link
Contributor

@MichaelGoberling MichaelGoberling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shazron
Copy link
Member

shazron commented Oct 31, 2023

I think we can do another 4.x patch release, then release this as 5.x.
Need to fix the issue that Michael commented on first though.

@purplecabbage
Copy link
Member Author

Checks have passed but they are not reported back here ...?

@purplecabbage purplecabbage merged commit 6974547 into master Dec 18, 2023
7 checks passed
@purplecabbage purplecabbage deleted the AudManOut branch December 18, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants